netdev - Re: [PATCH net-next] tcp: do not leak non zero tstamp in output packets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140307.143322.1145797644639586688.davem@davemloft.net>
Date:	Fri, 07 Mar 2014 14:33:22 -0500 (EST)
From:	David Miller <davem@...emloft.net>
To:	eric.dumazet@...il.com
Cc:	netdev@...r.kernel.org, willemb@...gle.com
Subject: Re: [PATCH net-next] tcp: do not leak non zero tstamp in output
 packets

From: Eric Dumazet <eric.dumazet@...il.com>
Date: Wed, 05 Mar 2014 14:08:38 -0800

> From: Eric Dumazet <edumazet@...gle.com>
> 
> Usage of skb->tstamp should remain private to TCP stack
> (only set on packets on write queue, not on cloned ones)
> 
> Otherwise, packets given to loopback interface with a non null tstamp
> can confuse netif_rx() / net_timestamp_check()
> 
> Other possibility would be to clear tstamp in loopback_xmit(),
> as done in skb_scrub_packet()
> 
> Fixes: 740b0f1841f6 ("tcp: switch rtt estimations to usec resolution")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: Willem de Bruijn <willemb@...gle.com>

Applied, thanks Eric.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html