netdev - Re: [PATCH] e1000: do not allow watchdog to reenable transmits on shutdown

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394227966.2101.4.camel@jtkirshe-mobl.jf.intel.com>
Date:	Fri, 07 Mar 2014 13:32:46 -0800
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Marcelo Tosatti <mtosatti@...hat.com>
Cc:	Vladimir Davydov <VDavydov@...allels.com>,
	e1000-devel@...ts.sourceforge.net, netdev@...r.kernel.org
Subject: Re: [PATCH] e1000: do not allow watchdog to reenable transmits on
 shutdown

On Fri, 2014-03-07 at 18:00 -0300, Marcelo Tosatti wrote:
> On Thu, Mar 06, 2014 at 07:24:31PM -0800, Jeff Kirsher wrote:
> > On Thu, 2014-03-06 at 23:04 -0300, Marcelo Tosatti wrote:
> > > 
> > > There is a race on the shutdown path of the e1000 driver
> > > that allows the card to DMA into free'd memory.
> > > 
> > > The symptoms are similar to those described at 
> > > commit d5bc77a223b0e9b9dfb002048d2b34a79e7d0b48,
> > > "e1000: don't enable dma receives until after dma address has been
> > > setup", where memory corruption is visible due to E1000_RXD_STAT_DD
> > > being written to the DMA transfer descriptor.
> > > 
> > > Fix by not allowing the watchdog and tx fifo stall detector
> > > to re-enable E1000_TCTL_EN.
> > > 
> > > Signed-off-by: Marcelo Tosatti <mtosatti@...hat.com>
> > 
> > Thanks I will add this to the queue.
> > 
> > Note- there are trailing whitespace issues and 2 comments are not
> > formatted correctly.  I can fix these up if there are no other issues
> > with the patch, if you want.
> 
> Ok, resent v2 with those fixed, must have inlined an older patch
> in the message, sorry.
> 

Thanks Marcelo, I will update the patch in my queue when I receive it.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)