netdev - Re: [PATCH] vmxnet3: fix netpoll race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <739029197.38929769.1394255661208.JavaMail.root@vmware.com>
Date:	Fri, 7 Mar 2014 21:14:21 -0800 (PST)
From:	Shreyas Bhatewara <sbhatewara@...are.com>
To:	Neil Horman <nhorman@...driver.com>
Cc:	netdev@...r.kernel.org, "VMware, Inc." <pv-drivers@...are.com>,
	"David S. Miller" <davem@...emloft.net>, stable@...r.kernel.org
Subject: Re: [PATCH] vmxnet3: fix netpoll race condition

Thanks for the patch Neil. 


> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -1762,11 +1762,13 @@ vmxnet3_netpoll(struct net_device *netdev)
>  {
>  	struct vmxnet3_adapter *adapter = netdev_priv(netdev);
>  
> -	if (adapter->intr.mask_mode == VMXNET3_IMM_ACTIVE)
> -		vmxnet3_disable_all_intrs(adapter);
> -
> -	vmxnet3_do_poll(adapter, adapter->rx_queue[0].rx_ring[0].size);
> -	vmxnet3_enable_all_intrs(adapter);
> +	switch (adapter->intr.type) {
> +	case VMXNET3_IT_MSIX:
> +		vmxnet3_msix_rx(0, &adapter->rx_queue[0]);

This should be called for each rx queue, just calling it for
1st queue does not suffice.
Also there should be a break; here


> +	case VMXNET3_IT_MSI:
> +	default:
> +		vmxnet3_intr(0, adapter->netdev);
> +	}
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html