netdev - Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531B934C.31666.37555A14@pageexec.freemail.hu>
Date:	Sat, 08 Mar 2014 23:01:48 +0100
From:	"PaX Team" <pageexec@...email.hu>
To:	behanw@...verseincode.com, Sergei Antonov <saproj@...il.com>
CC:	linville@...driver.com, johannes@...solutions.net,
	davem@...emloft.net,
	linux-wireless <linux-wireless@...r.kernel.org>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	dwmw2@...radead.org,
	"Jan-Simon Möller" <dl9pf@....de>,
	"Vinícius Tinti" <viniciustinti@...il.com>,
	Mark Charlebois <charlebm@...il.com>
Subject: Re: [PATCH v2] mac80211: LLVMLinux: Remove VLAIS usage from mac80211

On 8 Mar 2014 at 21:29, Sergei Antonov wrote:

> > -       memset(&aead_req, 0, sizeof(aead_req));
> > +       char aead_req_data[sizeof(struct aead_request) +
> > +                               crypto_aead_reqsize(tfm) +
> > +                               CRYPTO_MINALIGN] CRYPTO_MINALIGN_ATTR;
                                                     ^^^^^^^^^^^^^^^^^^^^
wouldn't the underlined attribute ensure the required alignment?

> Bad trick with regards to alignment.
> The alignment requirement for struct aead_request is stronger than
> what an array of chars may have.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html