lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sun, 9 Mar 2014 08:37:46 +0200
From:	Eli Cohen <eli@....mellanox.co.il>
To:	Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>
Cc:	Eli Cohen <eli@...lanox.com>, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org
Subject: Re: [PATCH] IB/mlx5_core: remove unreachable function call in module
 init

Acked-by: Eli Cohen <eli@...lanox.com>

On Fri, Mar 07, 2014 at 07:48:25PM -0300, Kleber Sacilotto de Souza wrote:
> The call to mlx5_health_cleanup() in the module init function can never
> be reached. Removing it.
> 
> Signed-off-by: Kleber Sacilotto de Souza <klebers@...ux.vnet.ibm.com>
> ---
>  drivers/net/ethernet/mellanox/mlx5/core/main.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> index 6f7c866..77ac95f 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/main.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/main.c
> @@ -531,7 +531,6 @@ static int __init init(void)
>  
>  	return 0;
>  
> -	mlx5_health_cleanup();
>  err_debug:
>  	mlx5_unregister_debugfs();
>  	return err;
> -- 
> 1.7.1
> 
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Powered by blists - more mailing lists