netdev - Re: [PATCH net-next v2 10/13] r8152: support IPv6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394394475.15968.25.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 09 Mar 2014 19:47:55 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Hayes Wang <hayeswang@...ltek.com>
Cc:	netdev@...r.kernel.org, nic_swsd@...ltek.com,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH net-next v2 10/13] r8152: support IPv6

On Wed, 2014-03-05 at 14:49 +0800, Hayes Wang wrote:
> Support hw IPv6 checksum for TCP and UDP packets.
> 
> Note that the hw has the limitation of the range of the transport
> offset. Besides, the TCP Pseudo Header of the IPv6 TSO of the hw
> bases on the Microsoft document which excludes the packet length.
> 
> Signed-off-by: Hayes Wang <hayeswang@...ltek.com>
> ---
>  drivers/net/usb/r8152.c | 107 ++++++++++++++++++++++++++++++++++++++++++++++--
>  1 file changed, 104 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 8f6d0f8..8e208f30 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
[...]
> +static int msdn_giant_send_check(struct sk_buff *skb)
> +{
> +	const struct ipv6hdr *ipv6h;
> +	struct tcphdr *th;
> +
> +	ipv6h = ipv6_hdr(skb);
> +	th = tcp_hdr(skb);
> +
> +	th->check = 0;
> +	th->check = ~tcp_v6_check(0, &ipv6h->saddr, &ipv6h->daddr, 0);
[...]

I think you need to call skb_cow_head() before editing the header here.

Ben.

-- 
Ben Hutchings
I say we take off; nuke the site from orbit.  It's the only way to be sure.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)