netdev - Re: [RCU PATCH 07/14] net: sched: RCU cls

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <531E142E.1050203@gmail.com>
Date:	Mon, 10 Mar 2014 12:36:14 -0700
From:	John Fastabend <john.fastabend@...il.com>
To:	Eric Dumazet <eric.dumazet@...il.com>
CC:	xiyou.wangcong@...il.com, jhs@...atatu.com, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [RCU PATCH 07/14] net: sched: RCU cls_route

On 03/10/2014 10:45 AM, Eric Dumazet wrote:
> On Mon, 2014-03-10 at 10:06 -0700, John Fastabend wrote:
>> RCUify the route classifier. For now however spinlock's are used to
>> protect fastmap cache.
>>
>> The issue here is the fastmap may be read by one CPU while the
>> cache is being updated by another. An array of pointers could be
>> one possible solution.
>>
>> Signed-off-by: John Fastabend <john.r.fastabend@...el.com>
>> ---

[...]

>> -route4_reset_fastmap(struct Qdisc *q, struct route4_head *head, u32 id)
>> +route4_reset_fastmap(struct route4_head *head)
>>   {
>> -	spinlock_t *root_lock = qdisc_root_sleeping_lock(q);
>> -
>> -	spin_lock_bh(root_lock);
>> +	spin_lock(&fastmap_lock);
>
> Dont you need spin_lock_bh() ?


Right this should be _bh. Thanks.


-- 
John Fastabend         Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html