netdev - Re: [PATCH net] x86: bpf_jit: support negative offsets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394493182.3607.60.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Mon, 10 Mar 2014 16:13:02 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Alexei Starovoitov <ast@...mgrid.com>
Cc:	"David S. Miller" <davem@...emloft.net>,
	Jan Seiffert <kaffeemonster@...glemail.com>,
	Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net] x86: bpf_jit: support negative offsets

On Mon, 2014-03-10 at 15:56 -0700, Alexei Starovoitov wrote:
> Commit a998d4342337 claimed to introduce negative offset support to x86 jit,
> but it couldn't be working, since at the time of the execution
> of LD+ABS or LD+IND instructions via call into
> bpf_internal_load_pointer_neg_helper() the %edx (3rd argument of this func)
> had junk value instead of access size in bytes (1 or 2 or 4).
> 
> Store size into %edx instead of %ecx (what original commit intended to do)
> 
> Fixes: a998d4342337 ("bpf jit: Let the x86 jit handle negative offsets")
> Signed-off-by: Alexei Starovoitov <ast@...mgrid.com>
> Cc: Jan Seiffert <kaffeemonster@...glemail.com>
> Cc: Eric Dumazet <edumazet@...gle.com>
> --
> This is a single bit patch. Is there a leaderboard of shortest patches? ;)

Acked-by: Eric Dumazet <edumazet@...gle.com>

Its actually a 1 byte or 3-bit patch ;)

'c' is 0x63, and 'd' is 0x64 ;)



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html