netdev - Re: [PATCH net-next] ipv6: ip6_forward: perform skb->pkt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140310.214901.1619965966009209363.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 21:49:01 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	roy.qing.li@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next] ipv6: ip6_forward: perform skb->pkt_type
 check at the beginning

From: roy.qing.li@...il.com
Date: Mon, 10 Mar 2014 13:10:20 +0800

> From: Li RongQing <roy.qing.li@...il.com> 
> 
> Packets which have L2 address different from ours should be
> already filtered before entering into ip6_forward().
> 
> Perform that check at the beginning to avoid processing such packets.
> And use unlikely to optimise.
> 
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>

Based upon Eric's feedback for your ipv4 patch, please remove
the unlikely() for this ipv6 one.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html