[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <1394546391.30915.13.camel@kazak.uk.xensource.com>
Date: Tue, 11 Mar 2014 13:59:51 +0000
From: Ian Campbell <Ian.Campbell@...rix.com>
To: Wei Liu <wei.liu2@...rix.com>
CC: <xen-devel@...ts.xen.org>, <netdev@...r.kernel.org>,
Annie Li <annie.li@...cle.com>,
Paul Durrant <paul.durrant@...rix.com>
Subject: Re: [PATCH net] xen-netback: use skb_is_gso in xenvif_start_xmit
On Tue, 2014-03-11 at 12:45 +0000, Wei Liu wrote:
> In 5bd076708 ("Xen-netback: Fix issue caused by using gso_type wrongly")
> we use skb_is_gso to determine if we need an extra slot to accommodate
> the SKB. There's similar error in interface.c. Change that to use
> skb_is_gso as well.
>
> Signed-off-by: Wei Liu <wei.liu2@...rix.com>
> Cc: Annie Li <annie.li@...cle.com>
Acked-by: Ian Campbell <ian.campbell@...rix.com>
> Cc: Paul Durrant <paul.durrant@...rix.com>
> ---
> drivers/net/xen-netback/interface.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/net/xen-netback/interface.c b/drivers/net/xen-netback/interface.c
> index 7669d49..301cc03 100644
> --- a/drivers/net/xen-netback/interface.c
> +++ b/drivers/net/xen-netback/interface.c
> @@ -132,8 +132,7 @@ static int xenvif_start_xmit(struct sk_buff *skb, struct net_device *dev)
> /* If the skb is GSO then we'll also need an extra slot for the
> * metadata.
> */
> - if (skb_shinfo(skb)->gso_type & SKB_GSO_TCPV4 ||
> - skb_shinfo(skb)->gso_type & SKB_GSO_TCPV6)
> + if (skb_is_gso(skb))
> min_slots_needed++;
>
> /* If the skb can't possibly fit in the remaining slots
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists