netdev - Re: [PATCH net-next v2 8/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOwfj2O8p2MQtFhaLrSzjRAnOYtR2qS3POXaaDd=3qtnwwovZg@mail.gmail.com>
Date:	Tue, 11 Mar 2014 10:35:00 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Stephen Hemminger <stephen@...workplumber.org>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next v2 8/9] Altera TSE: Add Miscellaneous Files for
 Altera Ethernet Driver

On Mon, Mar 10, 2014 at 7:40 PM, Stephen Hemminger
<stephen@...workplumber.org> wrote:
> On Mon, 10 Mar 2014 18:14:36 -0500
> Vince Bridgers <vbridgers2013@...il.com> wrote:
>
>> +
>> +     buf[0] = (u64) ioread32(&mac->frames_transmitted_ok);
>
> The cast to u64 is not really necessary, C will do it for you.
> You do need the cast to do the shift for the 64 bit values.

Ok, understood. I generally add the cast so it's explicit, but I'll modify.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html