netdev - Re: [PATCH net-next v2 2/9] net: ethernet: Change Ethernet Makefile and Kconfig for Altera TSE driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAOwfj2O_vZ=2Dah5qycV2-tVm1hG6OxrcHZSzqhM8+tWFUBtMw@mail.gmail.com>
Date:	Tue, 11 Mar 2014 10:46:19 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next v2 2/9] net: ethernet: Change Ethernet Makefile
 and Kconfig for Altera TSE driver

Hi Sergei,

On Tue, Mar 11, 2014 at 9:09 AM, Sergei Shtylyov
<sergei.shtylyov@...entembedded.com> wrote:
> Hello.
>
>
> On 11-03-2014 3:14, Vince Bridgers wrote:
>
>> This patch changes the Ethernet Makefile and Kconfig files to add the
>> Altera
>> Ethernet driver component.
>
>
>> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
>> ---
>> V2: - No change to Kconfig and Makefile from initial RFC review
>
>
>    Unfortunately, the order of patches seems wrong. This patch should be
> among the last.
>
>
>> ---
>>   drivers/net/ethernet/Kconfig  |    1 +
>>   drivers/net/ethernet/Makefile |    1 +
>>   2 files changed, 2 insertions(+)
>
>
>> diff --git a/drivers/net/ethernet/Kconfig b/drivers/net/ethernet/Kconfig
>> index 506b024..39484b5 100644
>> --- a/drivers/net/ethernet/Kconfig
>> +++ b/drivers/net/ethernet/Kconfig
>> @@ -22,6 +22,7 @@ source "drivers/net/ethernet/adaptec/Kconfig"
>>   source "drivers/net/ethernet/aeroflex/Kconfig"
>>   source "drivers/net/ethernet/allwinner/Kconfig"
>>   source "drivers/net/ethernet/alteon/Kconfig"
>> +source "drivers/net/ethernet/altera/Kconfig"
>
>
>    This file doesn't exist yet.
>
>
>>   source "drivers/net/ethernet/amd/Kconfig"
>>   source "drivers/net/ethernet/apple/Kconfig"
>>   source "drivers/net/ethernet/arc/Kconfig"
>> diff --git a/drivers/net/ethernet/Makefile b/drivers/net/ethernet/Makefile
>> index c0b8789..adf61af 100644
>> --- a/drivers/net/ethernet/Makefile
>> +++ b/drivers/net/ethernet/Makefile
>> @@ -8,6 +8,7 @@ obj-$(CONFIG_NET_VENDOR_ADAPTEC) += adaptec/
>>   obj-$(CONFIG_GRETH) += aeroflex/
>>   obj-$(CONFIG_NET_VENDOR_ALLWINNER) += allwinner/
>>   obj-$(CONFIG_NET_VENDOR_ALTEON) += alteon/
>> +obj-$(CONFIG_ALTERA_TSE) += altera/
>
>
>    This directory doesn't exist yet.
>
> WBR, Sergei
>

Understood, this was an oversight on my part when I created the
patchset. I'll address and respin.

Thank you for taking the time to review and comment,

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html