netdev - Re: [PATCH net V2] Xen-netback: Fix issue caused by using gso

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140310.215826.2152685771330034462.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 21:58:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Annie.li@...cle.com
Cc:	xen-devel@...ts.xen.org, netdev@...r.kernel.org,
	konrad.wilk@...cle.com, Ian.Campbell@...rix.com,
	wei.liu2@...rix.com, paul.durrant@...rix.com
Subject: Re: [PATCH net V2] Xen-netback: Fix issue caused by using gso_type
 wrongly

From: Annie Li <Annie.li@...cle.com>
Date: Mon, 10 Mar 2014 22:58:34 +0800

> From: Annie Li <annie.li@...cle.com>
> 
> Current netback uses gso_type to check whether the skb contains
> gso offload, and this is wrong. Gso_size is the right one to
> check gso existence, and gso_type is only used to check gso type.
> 
> Some skbs contains nonzero gso_type and zero gso_size, current
> netback would treat these skbs as gso and create wrong response
> for this. This also causes ssh failure to domu from other server.
> 
> V2: use skb_is_gso function as Paul Durrant suggested
> 
> Signed-off-by: Annie Li <annie.li@...cle.com>

Applied, thank you.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html