netdev - Re: [PATCH v2] vmxnet3: fix netpoll race condition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140311.161559.441950272628803826.davem@davemloft.net>
Date:	Tue, 11 Mar 2014 16:15:59 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	nhorman@...driver.com
Cc:	netdev@...r.kernel.org, sbhatewara@...are.com,
	pv-drivers@...are.com, stable@...r.kernel.org
Subject: Re: [PATCH v2] vmxnet3: fix netpoll race condition

From: Neil Horman <nhorman@...driver.com>
Date: Mon, 10 Mar 2014 06:55:55 -0400

> vmxnet3's netpoll driver is incorrectly coded.  It directly calls
> vmxnet3_do_poll, which is the driver internal napi poll routine.  As the netpoll
> controller method doesn't block real napi polls in any way, there is a potential
> for race conditions in which the netpoll controller method and the napi poll
> method run concurrently.  The result is data corruption causing panics such as this
> one recently observed:
 ...
> The fix is to do as other drivers do, and have the poll controller call the top
> half interrupt handler, which schedules a napi poll properly to recieve frames
> 
> Tested by myself, successfully.
> 
> Signed-off-by: Neil Horman <nhorman@...driver.com>

Applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html