netdev - Re: [PATCH] vlan: Set correct source MAC address with TX VLAN offload enabled

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140310.222226.1557956325482157663.davem@davemloft.net>
Date:	Mon, 10 Mar 2014 22:22:26 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	peter.bostrom@...rounds.com
Cc:	kaber@...sh.net, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] vlan: Set correct source MAC address with TX VLAN
 offload enabled

From: Peter Boström <peter.bostrom@...rounds.com>
Date: Mon, 10 Mar 2014 16:17:15 +0100

> With TX VLAN offload enabled the source MAC address for frames sent using the
> VLAN interface is currently set to the address of the real interface. This is
> wrong since the VLAN interface may be configured with a different address.
> 
> The bug was introduced in commit 2205369a314e12fcec4781cc73ac9c08fc2b47de
> ("vlan: Fix header ops passthru when doing TX VLAN offload.").
> 
> This patch sets the source address before calling the create function of the
> real interface.
> 
> Signed-off-by: Peter Boström <peter.bostrom@...rounds.com>

Good catch.

Applied and queued up for -stable, thanks!
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html