netdev - Re: net-next: NULL pointer dereference on adding a net namespace and a system freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140311053003.GA32371@secunet.com>
Date:	Tue, 11 Mar 2014 06:30:03 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Jakub Kiciński <moorray3@...pl>
CC:	Eric Dumazet <eric.dumazet@...il.com>, <netdev@...r.kernel.org>,
	Fan Du <fan.du@...driver.com>
Subject: Re: net-next: NULL pointer dereference on adding a net namespace and
 a system freeze

On Tue, Mar 11, 2014 at 01:46:49AM +0100, Jakub Kiciński wrote:
> On Mon, 10 Mar 2014 07:04:36 -0700, Eric Dumazet wrote:
> > On Mon, 2014-03-10 at 13:19 +0100, Jakub Kiciński wrote:
> > 
> > > It helps with the flow_cache warning and BUG ("ip netns add" works) but
> > > machine still freezes after 5-10 minutes.  I will try to revert
> > > ca925cf1534ebcec332c08719a7dee6ee1782ce4 and see if that solves it.
> > 
> > I think the other issue is separate. It might be triggered by
> > conntracking change.
> 
> I bisected the other issue to be caused/uncovered by:
> 
> commit 1a1ccc96abb2ed9b8fbb71018e64b97324caef53
> Author: Steffen Klassert <steffen.klassert@...unet.com>
> Date:   Wed Feb 19 10:07:34 2014 +0100
> 
>     xfrm: Remove caching of xfrm_policy_sk_bundles
>     
>     We currently cache socket policy bundles at xfrm_policy_sk_bundles.
>     These cached bundles are never used. Instead we create and cache
>     a new one whenever xfrm_lookup() is called on a socket policy.
>     
>     Most protocols cache the used routes to the socket, so let's
>     remove the unused caching of socket policy bundles in xfrm.
>     
>     Signed-off-by: Steffen Klassert <steffen.klassert@...unet.com>
> 
> 
> Machine freezes after FLOW_HASH_RND_PERIOD (default 10 minutes).

Hm, I used this for more than a month before I pushed it upstream.
But this was without the flowcache namespace changes, maybe this
interferes with the flowcache namespace changes.

I'll look into it, thanks for reporting and bisecting!

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html