netdev - Re: [RCU PATCH 06/14] net: sched: fw use RCU

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394643673.21721.48.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 12 Mar 2014 10:01:13 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	John Fastabend <john.fastabend@...il.com>
Cc:	xiyou.wangcong@...il.com, jhs@...atatu.com, netdev@...r.kernel.org,
	davem@...emloft.net
Subject: Re: [RCU PATCH 06/14] net: sched: fw use RCU

On Wed, 2014-03-12 at 09:41 -0700, John Fastabend wrote:

> Rearranging the rcu_head placement above results in this error:
> 
> net/sched/cls_fw.c: In function ‘fw_destroy’:
> net/sched/cls_fw.c:169:279: error: call to ‘__compiletime_assert_169’ 
> declared with attribute error: BUILD_BUG_ON failed: 
> !__is_kfree_rcu_offset(__builtin_offsetof(typeof(*(head)),rcu))
> 
> 
> However it seems best to have the rcu_head at the end of the struct
> so I'll just convert the kfree_rcu() to call_rcu().


I missed HTSIZE was so big.

Its unfortunate because it makes struct fw_head slightly larger than one
page.


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html