lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 12 Mar 2014 18:31:03 +0000 From: "Keller, Jacob E" <jacob.e.keller@...el.com> To: Sergei Shtylyov <sergei.shtylyov@...entembedded.com> CC: "Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>, "davem@...emloft.net" <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "gospo@...hat.com" <gospo@...hat.com>, "sassmann@...hat.com" <sassmann@...hat.com> Subject: Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints On Wed, 2014-03-12 at 18:51 +0400, Sergei Shtylyov wrote: > Hello. > > On 12-03-2014 9:53, Jeff Kirsher wrote: > > > From: Jacob Keller <jacob.e.keller@...el.com> > > > This patch fixes some formatting on multilined print messages, so that > > the text of the print appears on a single line, which aids in grepping > > the sourcecode for where the error came from. > > > Signed-off-by: Jacob Keller <jacob.e.keller@...el.com> > > Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com> > > Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com> > > --- > > drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c > > index 446df3c..3bc9b67 100644 > > --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c > > +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c > > @@ -512,7 +512,7 @@ out: > > * > > * Disables link, should be called during D3 power down sequence. > > * > > - */ > > + **/ > > Hm? What's this for? > The extra **/ is part of the standard doc format for function headers, and this was likely a fix to convert it to the standard format, though probably was meant to end up in a separate patch... I don't fully recall. Thanks, Jake > WBR, Sergei >
Powered by blists - more mailing lists