netdev - Re: [net-next 12/13] ixgbe: fix some multiline hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5320C263.9000105@cogentembedded.com>
Date:	Wed, 12 Mar 2014 23:24:03 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	"Keller, Jacob E" <jacob.e.keller@...el.com>
CC:	"Kirsher, Jeffrey T" <jeffrey.t.kirsher@...el.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"gospo@...hat.com" <gospo@...hat.com>,
	"sassmann@...hat.com" <sassmann@...hat.com>
Subject: Re: [net-next 12/13] ixgbe: fix some multiline hw_dbg prints

On 03/12/2014 11:11 PM, Sergei Shtylyov wrote:

>>>> From: Jacob Keller <jacob.e.keller@...el.com>

>>>> This patch fixes some formatting on multilined print messages, so that
>>>> the text of the print appears on a single line, which aids in grepping
>>>> the sourcecode for where the error came from.

>>>> Signed-off-by: Jacob Keller <jacob.e.keller@...el.com>
>>>> Tested-by: Phil Schmitt <phillip.j.schmitt@...el.com>
>>>> Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
>>>> ---
>>>>    drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c | 8 +++-----
>>>>    1 file changed, 3 insertions(+), 5 deletions(-)

>>>> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> index 446df3c..3bc9b67 100644
>>>> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_82599.c
>>>> @@ -512,7 +512,7 @@ out:
>>>>     *
>>>>     * Disables link, should be called during D3 power down sequence.
>>>>     *
>>>> - */
>>>> + **/

>>>      Hm? What's this for?

>> The extra **/ is part of the standard doc format for function headers,

>     It is not. Reread Documentation/kernel-doc-nano-HOWTO.txt please.

    Sorry, I messed it myself -- it seems to be an optional part of the format 
which I've never seen actually used. Anyway, you shouldn't do "drove-by" 
changes like that, moreover undocumented in the change log.

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html