netdev - RE: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <008601cf3e2d$583b5e90$08b21bb0$@opengridcomputing.com>
Date:	Wed, 12 Mar 2014 14:57:49 -0500
From:	"Steve Wise" <swise@...ngridcomputing.com>
To:	"'David Miller'" <davem@...emloft.net>, <hariprasad@...lsio.com>
Cc:	<netdev@...r.kernel.org>, <linux-rdma@...r.kernel.org>,
	<roland@...estorage.com>, <dm@...lsio.com>, <leedom@...lsio.com>,
	<santosh@...lsio.com>, <kumaras@...lsio.com>,
	<nirranjan@...lsio.com>
Subject: RE: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Wednesday, March 12, 2014 2:51 PM
> To: hariprasad@...lsio.com
> Cc: netdev@...r.kernel.org; linux-rdma@...r.kernel.org; roland@...estorage.com;
> dm@...lsio.com; swise@...ngridcomputing.com; leedom@...lsio.com;
> santosh@...lsio.com; kumaras@...lsio.com; nirranjan@...lsio.com
> Subject: Re: [PATCHv6 net-next 00/31] Misc. fixes for cxgb4 and iw_cxgb4
> 
> From: Hariprasad Shenai <hariprasad@...lsio.com>
> Date: Wed, 12 Mar 2014 21:20:15 +0530
> 
> > V6:
> >    In patch 8/31, move the existing neigh_release() call right before the
> >    if(!e) test, that way you don't need a completely new label and code block
> >    to fix this bug - thanks to review by David Miller
> >    In patch 15/31, use %pad to print dma_addr - thanks to review by Joe Perches
> >    In patch 10/31, add the "STOPPED" state string to db_state_str - thanks
> >    to review by Steve Wise
> >    In patch 10/31, t4_db_dropped() needs to disable dbs and send DB_FULL
> >    event to iw_cxgb4 - thanks to review by Steve Wise
> > V5:
> >    Dropped patch "cxgb4: use spinlock_irqsave/spinlock_irqrestore for db lock".
> 
> I do not see the spinlock patch reinstated, part of it was correct and
> fixed a real bug.  For the second time, I only stated that parts of it
> were superfluous, not all of it.
> 

Ok we can reinstate this patch and remove the bits from 10/31 if that's what you prefer.

Steve.

BTW: From my earlier reply explaining that we didn't drop the needed fixes:

The remaining changes from the removed patch are moved into patch 10/31
(Doorbell Drop Avoidance Bug Fixes).  10/31 has the driver call
disable_txq_db() from an interrupt handler, and I thought it would be
better to put all the changes to fix how the db lock is acquired into
this one patch.   

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html