netdev - Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port switch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394655671.20857.2.camel@deadeye.wl.decadent.org.uk>
Date:	Wed, 12 Mar 2014 20:21:11 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Yegor Yefremov <yegorslists@...glemail.com>
Cc:	David Miller <davem@...emloft.net>, Stefan Roese <sr@...x.de>,
	netdev <netdev@...r.kernel.org>, "r.meier" <r.meier@...mens.com>,
	"lukas.stockmann" <lukas.stockmann@...mens.com>,
	Florian Fainelli <f.fainelli@...il.com>
Subject: Re: [PATCH] net: phy: Add support for SMSC/Microchip LAN9303 3-port
 switch

On Wed, 2014-03-12 at 09:43 +0100, Yegor Yefremov wrote:
> On Tue, Mar 11, 2014 at 9:39 PM, David Miller <davem@...emloft.net> wrote:
> > From: Yegor Yefremov <yegorslists@...glemail.com>
> > Date: Tue, 11 Mar 2014 21:11:16 +0100
> >
> >> On Fri, Feb 28, 2014 at 7:00 PM, David Miller <davem@...emloft.net> wrote:
> >>> From: Stefan Roese <sr@...x.de>
> >>> Date: Fri, 28 Feb 2014 10:32:20 +0100
> >>>
> >>>> On 27.02.2014 23:02, David Miller wrote:
> >>>>> From: Stefan Roese <sr@...x.de>
> >>>>> Date: Thu, 27 Feb 2014 10:07:52 +0100
> >>>>>
> >>>>> Better is to come up with a real, types, interface for programming
> >>>>> such devices and providing an implementation of that.
> >>>>
> >>>> Right. Such a thing would be better. But as Florian already pointed
> >>>> out, nothing like this is available in kernel.org right now. Thats the
> >>>> reason why I chose to implement this "simple" driver, btw as done in
> >>>> drivers/net/phy/spi_ks8995.c.
> >>>
> >>> When a suitable user facing interface is lacking, you create one
> >>> and submit it for review here.  You don't just submit adhoc driver
> >>> local stuff.
> >>
> >> David, what about enabling ethtool to read/write from/to the PHY
> >> registers (via passing PHY ID and register number)? I'm trying to get
> >> ICplus IP175D running and it has lots of registers, that I would like
> >> to look at dynamically.
> >
> > For debugging, register dumps are already supported by ethtool.
> 
> Do you mean 'ethtool -e' option? AFAIK it dumps Ethernet controller
> regs, if it implements ethtool_ops.get_regs(). What I need are PHY
> registers, that I can get via MII interface. ethtool should provide
> access to PHY registers like mdiobus_read() and mdiobus_write()
> routines.
[...]

Perhaps, but only as a test/debug interface.  It is not acceptable as a
production configuration interface - that needs some abstraction so the
same command will work on any switch chip that can support the
operation.

Ben.

-- 
Ben Hutchings
Any sufficiently advanced bug is indistinguishable from a feature.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)