netdev - Re: [PATCH net-next V4 6/9] Altera TSE: Add main and header file for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394656962.3915.41.camel@joe-AO722>
Date:	Wed, 12 Mar 2014 13:42:42 -0700
From:	Joe Perches <joe@...ches.com>
To:	Vince Bridgers <vbridgers2013@...il.com>
Cc:	devicetree@...r.kernel.org, netdev@...r.kernel.org,
	linux-doc@...r.kernel.org, robh+dt@...nel.org, pawel.moll@....com,
	mark.rutland@....com, ijc+devicetree@...lion.org.uk,
	galak@...eaurora.org, rob@...dley.net
Subject: Re: [PATCH net-next V4 6/9] Altera TSE: Add main and header file
 for Altera Ethernet Driver

On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
> This patch adds the main driver and header file for the Altera Triple
> Speed Ethernet driver.
[]
> diff --git a/drivers/net/ethernet/altera/altera_tse.h b/drivers/net/ethernet/altera/altera_tse.h
[]
> +/* MAC register Space. Note that some of these registers may or may not be
> + * present depending upon options chosen by the user when the core was
> + * configured and built. Please consult the Altera Triple Speed Ethernet User
> + * Guide for details.
> + */
> +struct altera_tse_mac {
> +	/* Bits 15:0: MegaCore function revision (0x0800). Bit 31:16: Customer
> +	 * specific revision
> +	 */
> +	unsigned int megacore_revision;
> +	/* Provides a memory location for user applications to test the device
> +	 * memory operation.
> +	 */
> +	unsigned int scratch_pad;
> +	/* The host processor uses this register to control and configure the
> +	 * MAC block
> +	 */
> +	unsigned int command_config;
> +	/* 32-bit primary MAC address word 0 bits 0 to 31 of the primary
> +	 * MAC address
> +	 */
> +	unsigned int mac_addr_0;
> +	/* 32-bit primary MAC address word 1 bits 32 to 47 of the primary
> +	 * MAC address
> +	 */

maybe all of these should be specifically sized using u32 like

	u32 mac_addr_0;


--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html