netdev - Re: [PATCH net-next 02/10] 8139too: Call dev_kfree_skby_any instead of dev_kfree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394661695.21721.50.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 12 Mar 2014 15:01:35 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Francois Romieu <romieu@...zoreil.com>
Cc:	"Eric W. Biederman" <ebiederm@...ssion.com>,
	David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH net-next 02/10] 8139too: Call dev_kfree_skby_any instead
 of dev_kfree_skb.

On Wed, 2014-03-12 at 22:24 +0100, Francois Romieu wrote:
> Eric Dumazet <eric.dumazet@...il.com> :
> [...]
> > Same u64_stats_fetch_begin_bh() problem for this driver to fetch TX
> > stats.
> 
> Same problem for any NAPI context Tx completing driver that claims
> netpoll support. For instance:
> drivers/net/ethernet/emulex/benet
> drivers/net/ethernet/intel/i40e
> drivers/net/ethernet/intel/igb
> drivers/net/ethernet/intel/ixgbe
> drivers/net/ethernet/marvell/sky2.c
> drivers/net/ethernet/neterion/vxge ?
> 
> Similar problem for the drivers below. They update Tx stats in start_xmit
> and use u64_.*_bh:
> drivers/net/ethernet/tile/tilepro.c
> drivers/net/team/team.c
> drivers/net/virtio_net.c
> 

Yep, note that this issue is not caused by Eric patches, we need to take
care of this by providing u64_stats_fetch_{begin|retry}_irq() regardless
of how skb are freed.



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html