netdev - Re: [PATCHv6 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window based on link speed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140312.181245.1921772176964395946.davem@davemloft.net>
Date:	Wed, 12 Mar 2014 18:12:45 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	swise@...ngridcomputing.com
Cc:	hariprasad@...lsio.com, netdev@...r.kernel.org,
	linux-rdma@...r.kernel.org, roland@...estorage.com, dm@...lsio.com,
	leedom@...lsio.com, santosh@...lsio.com, kumaras@...lsio.com,
	nirranjan@...lsio.com
Subject: Re: [PATCHv6 net-next 20/31] iw_cxgb4: adjust tcp snd/rcv window
 based on link speed

From: "Steve Wise" <swise@...ngridcomputing.com>
Date: Wed, 12 Mar 2014 16:29:27 -0500

>> >> You can just use the TCP settings the kernel already provides for
>> >> the real TCP stack.
>> >
>> > Do you mean use sysctl_tcp_*mem, sysctl_tcp_timestamps, sysctl_tcp_window_scaling,
> etc?
>> > I'll look into this.
>> 
>> And the socket memory limits, which we use to compute default window
>> sizes.
> 
> How's this look (compile-tested only)?  Note I had to export some of the tcp limits.

Well, the problem is that you've dug your own hole already.

You can't just remove these existing module parameters that users can
set.  They are user visible APIs, you can't just remove them.

The best you can do is stop adding new ones.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html