netdev - Re: [PATCH net-next 0/3] bonding: support 802.1ad vlan protocol

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140312061353.GA2924@redhat.com>
Date:	Wed, 12 Mar 2014 07:13:53 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	Ding Tianhong <dingtianhong@...wei.com>
Cc:	fubar@...ibm.com, andy@...yhouse.net, kaber@...sh.net,
	davem@...emloft.net, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 0/3] bonding: support 802.1ad vlan protocol

On Tue, Mar 11, 2014 at 11:43:39AM +0800, Ding Tianhong wrote:
>The bonding could only use vlan proto 802.1q regardless the vlan dev is
>802.1ad or 802.1q, so add new interface to get vlan proto by vlan dev and
>use it to send packages by correct vlan protocol.

It's not that easy. 802.1ad packets should be double-tagged, however you're
just changing the protocol (from 1q to 1ad) and tagging just once.

Have you actually tested this patchset, does it produce correct QinQ
packets?

>
>Ding Tianhong (3):
>  vlan: make a new function  vlan_dev_vlan_proto() and export
>  bonding: support different vlan proto for bond_arp_send()
>  bonding: choose the correct vlan proto for alb_send_learning_packets
>
> drivers/net/bonding/bond_alb.c  |  7 ++++---
> drivers/net/bonding/bond_main.c | 23 +++++++++++++++--------
> include/linux/if_vlan.h         |  7 +++++++
> net/8021q/vlan_core.c           |  6 ++++++
> 4 files changed, 32 insertions(+), 11 deletions(-)
>
>-- 
>1.8.0
>
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html