netdev - Re: net-next: NULL pointer dereference on adding a net namespace and a system freeze

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140312083827.GE32371@secunet.com>
Date:	Wed, 12 Mar 2014 09:38:27 +0100
From:	Steffen Klassert <steffen.klassert@...unet.com>
To:	Jakub Kiciński <moorray3@...pl>
CC:	Eric Dumazet <eric.dumazet@...il.com>, <netdev@...r.kernel.org>,
	Fan Du <fan.du@...driver.com>
Subject: Re: net-next: NULL pointer dereference on adding a net namespace and
 a system freeze

On Tue, Mar 11, 2014 at 03:30:29PM +0100, Jakub Kiciński wrote:
> 
> Tested with del_timer_sync and unregister_hotcpu_notifier:
> 
> void flow_cache_fini(struct net *net)
> {
> 	int i;
> 	struct flow_cache *fc = &net->xfrm.flow_cache_global;
> 
> 	unregister_hotcpu_notifier(&fc->hotcpu_notifier);
> 	del_timer_sync(&fc->rnd_timer);
> 
> 	for_each_possible_cpu(i) {
> 		struct flow_cache_percpu *fcp = per_cpu_ptr(fc->percpu, i);
> 		kfree(fcp->hash_table);
> 		fcp->hash_table = NULL;
> 	}
> 
> 	free_percpu(fc->percpu);
> 	fc->percpu = NULL;
> }
> EXPORT_SYMBOL(flow_cache_fini);
> 
> 
> Seems to solve both the freeze and the bug on restarting libvirtd/rtkit!
> 

Thanks a lot for testing!

I'll submit the updated patch now.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html