netdev - RE: [PATCH v3 net-next 1/2] ethtool: Support for configurable RSS hash key

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <BF3270C86E8B1349A26C34E4EC1C44CB2C88E4CF@CMEXMB1.ad.emulex.com>
Date:	Wed, 12 Mar 2014 08:59:36 +0000
From:	Venkata Duvvuru <VenkatKumar.Duvvuru@...lex.Com>
To:	Ben Hutchings <ben@...adent.org.uk>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH v3 net-next 1/2] ethtool: Support for configurable RSS
 hash key

> > > > Why is 0xDEADBEEF special?
> > > Since 0 is used as a hint to reset to default, we should have a way
> > > to hint that indirection table configuration is not requested in
> > > this context.
> >
> > That's not necessary, as you can read and then write back the same values.
> >
> > Ben.
>


> May be this is extremely hypothetical but what if a driver doesn't want to
> support indirection configuration and only wants to support hash key
> configuration.
> In such a case, the kernel should know that are no entries of indirection in
> rss_config. Also I think it's better to keep hash key and indirection
> configurations independent of each other.

Ben, please let me know your opinion on my above comment. Thanks.