netdev - Re: [PATCH net-next] bcm63xx_enet: Stop pretending to support netpoll

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcYFy5wr0fvdsLdo7G0GC-kmJ-tjR=sG70hFMJK5oYcr4A@mail.gmail.com>
Date:	Thu, 13 Mar 2014 12:42:22 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	ebiederm@...ssion.com, Eric Dumazet <eric.dumazet@...il.com>,
	netdev <netdev@...r.kernel.org>,
	Cong Wang <xiyou.wangcong@...il.com>, mpm@...enic.com,
	satyam.sharma@...il.com
Subject: Re: [PATCH net-next] bcm63xx_enet: Stop pretending to support netpoll

2014-03-13 12:26 GMT-07:00 David Miller <davem@...emloft.net>:
> From: ebiederm@...ssion.com (Eric W. Biederman)
> Date: Tue, 11 Mar 2014 14:33:35 -0700
>
>> bcm_enet_netpoll does not exist, and causing
>> bcm63xx_net to fail to build when NET_POLL_CONTROLLER
>> is defined.
>>
>> Remove the bogus .ndo_poll_controller = bcm_enet_netpoll
>>
>> Signed-off-by: "Eric W. Biederman" <ebiederm@...ssion.com>
>
> Applied.
>
> This driver doesn't get a lot of build testing, and that's due to the
> platform BCM63XX kconfig option it depends upon.  Probably it should
> be exposed more widely to perhaps a more broad dependency such as
> CONFIG_OF.

There is no OF-aware platform using that driver. Part of the reason
why it does not get much build coverage is the large header
dependencies provided by arch/mips/include/asm/mach-bcm63xx. I will
work on improving that.
-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html