netdev - Re: [PATCH net] bonding: set correct vlan id for alb xmit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140313.154532.1174268119094634467.davem@davemloft.net>
Date:	Thu, 13 Mar 2014 15:45:32 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	dingtianhong@...wei.com
Cc:	fubar@...ibm.com, vfalico@...hat.com, andy@...yhouse.net,
	netdev@...r.kernel.org
Subject: Re: [PATCH net] bonding: set correct vlan id for alb xmit path

From: Ding Tianhong <dingtianhong@...wei.com>
Date: Wed, 12 Mar 2014 17:31:59 +0800

> The commit d3ab3ffd1d728d7ee77340e7e7e2c7cfe6a4013e
> (bonding: use rlb_client_info->vlan_id instead of ->tag)
> remove the rlb_client_info->tag, but occur some issues,
> The vlan_get_tag() will return 0 for success and -EINVAL for
> error, so the client_info->vlan_id always be set to 0 if the
> vlan_get_tag return 0 for success, so the client_info would
> never get a correct vlan id.
> 
> We should only set the vlan id to 0 when the vlan_get_tag return error.
> 
> Fixes: d3ab3ffd1d7 (bonding: use rlb_client_info->vlan_id instead of ->tag)
> 
> CC: Ding Tianhong <dingtianhong@...wei.com>
> CC: Jay Vosburgh <fubar@...ibm.com>
> CC: Andy Gospodarek <andy@...yhouse.net>
> Signed-off-by: Ding Tianhong <dingtianhong@...wei.com>

Applied, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html