netdev - Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for Altera Ethernet Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 12 Mar 2014 19:42:35 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	Joe Perches <joe@...ches.com>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next v3 5/9] Altera TSE: Add Miscellaneous Files for
 Altera Ethernet Driver

On Wed, Mar 12, 2014 at 7:28 PM, Ben Hutchings <ben@...adent.org.uk> wrote:
> On Wed, 2014-03-12 at 15:26 -0700, Joe Perches wrote:
>> On Wed, 2014-03-12 at 21:14 +0000, Ben Hutchings wrote:
>> > These look like the statistic names specified in IEEE 802.3.  I would
>> > support a general move to using standard names for MAC stats in Ethernet
>> > drivers, because they are quite clearly defined and widely implemented
>> > in hardware.  However, that is not the current practice in most Linux
>> > drivers.
>>
>> Hey Ben.
>>
>> Maybe something like this would be a start?
>>
>> Change the actual #defines/strings to taste.
>>
>> Maybe this shouldn't be in uapi or maybe in if_ether.h
> [...]
>
> This is pointless without also nailing down the definition of each
> statistic.  That could be done with reference to standards/RFCs, of
> course.

As I was working through the V4 patch and looking at the names used by
other drivers, it occurred to me it would be useful to create a set of
standard definitions that referenced the relevant IEEE Specification
and RFC. I'm willing to take that on for this submission by adding
those to the driver documentation. I think that would be useful to
users and could then be moved to a "standard definitions" text file
that other drivers could reference.

Joe had a few more comments I'd like to address (thanks Joe), I could
pick this up as part of a V5 submission if you agree, or if you have a
different suggestion I could possibly take that on as well.

>
> Ben.
>
> --
> Ben Hutchings
> Experience is directly proportional to the value of equipment destroyed.
>                                                          - Carolyn Scheppner

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html