netdev - Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140313064521.GH20224@mtldesk30>
Date:	Thu, 13 Mar 2014 08:45:22 +0200
From:	Eli Cohen <eli@....mellanox.co.il>
To:	Ben Hutchings <ben@...adent.org.uk>
Cc:	clsoto@...ux.vnet.ibm.com, eli@...lanox.com, roland@...nel.org,
	sean.hefty@...el.com, hal.rosenstock@...il.com,
	linux-rdma@...r.kernel.org, netdev@...r.kernel.org,
	brking@...ux.vnet.ibm.com
Subject: Re: [Patch 1/2] IB/mlx5: Implementation of PCI error handler

On Wed, Mar 12, 2014 at 06:34:12PM +0000, Ben Hutchings wrote:
> >  
> >  enum {
> > -       /* one minute for the sake of bringup. Generally, commands must always
> > +       /* 10 msecs for the sake of bringup. Generally, commands must always
> >          * complete and we may need to increase this timeout value
> >          */
> > -       MLX5_CMD_TIMEOUT_MSEC   = 7200 * 1000,
> > +       MLX5_CMD_TIMEOUT_MSEC   = 10 * 1000,
> 
> You seem to be changing the timeout from 2 hours (not one minute) to 10
> seconds (not milliseconds).
> 
Thanks for noting this. Actually, the time should remain 2 hours and
the comment should be fixed. Also note that long time/missing
completion of a command is, genrallly, not indicative of a PCI error.
If that happens, we would want to have enough time to do diagnostics
before timing out.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html