netdev - Re: [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver MSGDMA File Components

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOwfj2NUjVZjg2KinBNA9pRBBbUWhw86GcXEaLdmAyK_1SPfDQ@mail.gmail.com>
Date:	Wed, 12 Mar 2014 19:48:28 -0500
From:	Vince Bridgers <vbridgers2013@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-doc@...r.kernel.org" <linux-doc@...r.kernel.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"pawel.moll@....com" <pawel.moll@....com>,
	"mark.rutland@....com" <mark.rutland@....com>,
	"ijc+devicetree@...lion.org.uk" <ijc+devicetree@...lion.org.uk>,
	Kumar Gala <galak@...eaurora.org>,
	Rob Landley <rob@...dley.net>
Subject: Re: [PATCH net-next V4 3/9] Altera TSE: Add Altera Ethernet Driver
 MSGDMA File Components

Hi Joe,

On Wed, Mar 12, 2014 at 3:31 PM, Joe Perches <joe@...ches.com> wrote:
> On Wed, 2014-03-12 at 15:15 -0500, Vince Bridgers wrote:
>> This patch adds the MSGDMA soft IP support for the Altera Triple
>> Speed Ethernet driver.
>
> []
>
>> Signed-off-by: Vince Bridgers <vbridgers2013@...il.com>
>> ---
>> V4: - Modify use of dev_* to netdev_* where possible
>
> Hi again Vince.
>
> trivia:
>
> It'd be better to also use the netif_<foo> forms too.
>
> This can be done later in a follow-on patch if desired.
>
>> diff --git a/drivers/net/ethernet/altera/altera_msgdma.c b/drivers/net/ethernet/altera/altera_msgdma.c
> []
>> +void msgdma_reset(struct altera_tse_private *priv)
>> +{
> []
>> +     if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
>> +         (netif_msg_drv(priv)))
>> +             netdev_warn(priv->dev,
>> +                         "TSE Rx mSGDMA resetting bit never cleared!\n");
>
>         if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
>                 netif_warn(priv, drv, priv->dev,
>                            "TSE Rx mSGDMA resetting bit never cleared!\n");
>
> []
>
>> +     if ((counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR) &&
>> +         (netif_msg_drv(priv)))
>> +             netdev_warn(priv->dev,
>> +                         "TSE Tx mSGDMA resetting bit never cleared!\n");
>
>         if (counter >= ALTERA_TSE_SW_RESET_WATCHDOG_CNTR)
>                 netif_warn(priv, drv, priv->dev,
>                            "TSE Tx mSGDMA resetting bit never cleared!\n");
>
> cheers, Joe
>

You had mentioned this before, I guess I missed this. My apologies,
I'll pick this up in V5 with the misc other improvements.

All the best,

Vince
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html