netdev - Re: [PATCH net-next 2/2] bonding: use the correct ether type for alb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140314184251.GA30498@redhat.com>
Date:	Fri, 14 Mar 2014 19:42:52 +0100
From:	Veaceslav Falico <vfalico@...hat.com>
To:	David Miller <davem@...emloft.net>
Cc:	netdev@...r.kernel.org, fubar@...ibm.com, andy@...yhouse.net
Subject: Re: [PATCH net-next 2/2] bonding: use the correct ether type for alb

On Fri, Mar 14, 2014 at 02:29:35PM -0400, David Miller wrote:
>From: Veaceslav Falico <vfalico@...hat.com>
>Date: Thu, 13 Mar 2014 12:41:58 +0100
>
>> @@ -1005,7 +1005,7 @@ static void alb_send_lp_vid(struct slave *slave, u8 mac_addr[],
>>  	memset(&pkt, 0, size);
>>  	ether_addr_copy(pkt.mac_dst, mac_addr);
>>  	ether_addr_copy(pkt.mac_src, mac_addr);
>> -	pkt.type = cpu_to_be16(ETH_P_LOOP);
>> +	pkt.type = cpu_to_be16(ETH_P_LOOPBACK);
>
>Had this really never worked properly at all?

Yep, but only in cases where the hw/sw didn't filter out broken packets
*before* arp processing, as far as I can tell.

>
>It's been this way since the beginning of GIT history, and I imagine
>since the learning packet code even existed.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html