netdev - Re: [net-next 01/16] ixgbe: add check for netif_carrier_ok in ixgbe_xmit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140314.175131.1233519777786848021.davem@davemloft.net>
Date:	Fri, 14 Mar 2014 17:51:31 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	emil.s.tantilov@...el.com
Cc:	jeffrey.t.kirsher@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com, asharma@...com,
	stable@...r.kernel.org
Subject: Re: [net-next 01/16] ixgbe: add check for netif_carrier_ok in
 ixgbe_xmit_frame

From: "Tantilov, Emil S" <emil.s.tantilov@...el.com>
Date: Fri, 14 Mar 2014 20:19:38 +0000

> That would work, but what if there are other callers of
> ndo_start_xmit that don't have this check? Handling this in the
> driver takes care of all instances.

netif_carrier_off() is supposed to stop traffic from flowing to
the device.

The qdisc layer should be honoring this property, and my
suspicion is that it is just netpoll operates in the unique
environment that doesn't.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html