netdev - Re: [PATCH v2 1/4] net: add name_assign

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1394997429.15764.116.camel@deadeye.wl.decadent.org.uk>
Date:	Sun, 16 Mar 2014 19:17:09 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	David Herrmann <dh.herrmann@...il.com>
Cc:	netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
	Tom Gundersen <teg@...m.no>,
	Johannes berg <johannes@...solutions.net>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH v2 1/4] net: add name_assign_type netdev attribute

On Sun, 2014-03-16 at 18:21 +0100, David Herrmann wrote:
[...]
> --- a/include/linux/netdevice.h
> +++ b/include/linux/netdevice.h
> @@ -74,6 +74,11 @@ void netdev_set_default_ethtool_ops(struct net_device *dev,
>  #define NET_RX_SUCCESS		0	/* keep 'em coming, baby */
>  #define NET_RX_DROP		1	/* packet dropped */
>  
> +/* interface name assignment types */
> +#define NET_NAME_ENUM		0	/* enumerated by kernel (default) */
> +#define NET_NAME_USER		1	/* provided by user-space */
> +#define NET_NAME_RENAMED	2	/* renamed by user-space */
[...]

I think these definitions should be put in a UAPI header.  Even if the
names don't end up being used by userland, that would make it clear that
the numbers are a stable ABI.

Ben.

-- 
Ben Hutchings
Computers are not intelligent.	They only think they are.

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)