netdev - Re: [E1000-devel] [PATCH net-next] i40e: fix function kernel doc description

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 16 Mar 2014 23:15:40 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Jean Sacren <sakiwit@...il.com>
Cc:	"e1000-devel@...ts.sourceforge.net" 
	<e1000-devel@...ts.sourceforge.net>,
	netdev <netdev@...r.kernel.org>,
	Joseph Gasparakis <joseph.gasparakis@...el.com>,
	Jesse Brandeburg <jesse.brandeburg@...el.com>
Subject: Re: [E1000-devel] [PATCH net-next] i40e: fix function kernel doc description

On Sun, Mar 16, 2014 at 2:41 PM, Jean Sacren <sakiwit@...il.com> wrote:
> The commit c7d05ca89f8e ("i40e: driver ethtool core") introduced the
> new function i40e_add_del_fdir_sctpv4() with the kernel doc
> description a little bit off. The trivial error was copied over to a
> different file by the commit 17a73f6b1401 ("i40e: Flow Director
> sideband accounting") most recently. Fix the kernel doc with the
> correct description for clarity.
>
> Signed-off-by: Jean Sacren <sakiwit@...il.com>
> Cc: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Cc: Joseph Gasparakis <joseph.gasparakis@...el.com>
> ---
>  drivers/net/ethernet/intel/i40e/i40e_txrx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Thanks Jean, I will add your patch to my queue.

> diff --git a/drivers/net/ethernet/intel/i40e/i40e_txrx.c b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> index 88666adb0743..a53c4bcada79 100644
> --- a/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> +++ b/drivers/net/ethernet/intel/i40e/i40e_txrx.c
> @@ -299,7 +299,7 @@ static int i40e_add_del_fdir_tcpv4(struct i40e_vsi *vsi,
>   * @raw_packet: the pre-allocated packet buffer for FDir
>   * @add: true adds a filter, false removes it
>   *
> - * Returns 0 if the filters were successfully added or removed
> + * Always returns -EOPNOTSUPP
>   **/
>  static int i40e_add_del_fdir_sctpv4(struct i40e_vsi *vsi,
>                                     struct i40e_fdir_filter *fd_data,
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html