netdev - Re: [PATCH net-next 1/2] net: phy: bcm7xxx: fix spurious MDIO failures during workaround

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140317.160436.1560449781844166790.davem@davemloft.net>
Date:	Mon, 17 Mar 2014 16:04:36 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	f.fainelli@...il.com
Cc:	netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/2] net: phy: bcm7xxx: fix spurious MDIO
 failures during workaround

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri, 14 Mar 2014 16:09:04 -0700

> @@ -87,21 +87,6 @@ static void phy_write_misc(struct phy_device *phydev,
>  
>  static int bcm7xxx_28nm_afe_config_init(struct phy_device *phydev)
>  {
> -	/* write AFE_RXCONFIG_0 */
> -	phy_write_misc(phydev, 0x38, 0x0000, 0xeb19);
> -
> -	/* write AFE_RXCONFIG_1 */
> -	phy_write_misc(phydev, 0x38, 0x0001, 0x9a3f);
> -
> -	/* write AFE_RX_LP_COUNTER */
> -	phy_write_misc(phydev, 0x38, 0x0003, 0x7fc7);
> -
> -	/* write AFE_HPF_TRIM_OTHERS */
> -	phy_write_misc(phydev, 0x3A, 0x0000, 0x000b);
> -
> -	/* write AFTE_TX_CONFIG */
> -	phy_write_misc(phydev, 0x39, 0x0000, 0x0800);
> -
 ...
> +	/* write AFE_RXCONFIG_0 */
> +	phy_write_misc(phydev, 0x38, 0x0000, 0xeb19);
> +
> +	/* write AFE_RXCONFIG_1 */
> +	phy_write_misc(phydev, 0x38, 0x0001, 0x9a3f);
> +
> +	/* write AFE_RX_LP_COUNTER */
> +	phy_write_misc(phydev, 0x38, 0x0003, 0x7fc7);
> +
> +	/* write AFE_HPF_TRIM_OTHERS */
> +	phy_write_misc(phydev, 0x3A, 0x0000, 0x000b);
> +
> +	/* write AFTE_TX_CONFIG */
> +	phy_write_misc(phydev, 0x39, 0x0000, 0x0800);
> +
> +
>  	return 0;
>  }
>  

If you can use mnenomics in the _comment_ you can certainly do so in
the code too.

I want defines added for the address and content of these registers.

Thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html