netdev - RE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive Side Scaling (vRSS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 17 Mar 2014 20:54:00 +0000
From:	Haiyang Zhang <haiyangz@...rosoft.com>
To:	David Miller <davem@...emloft.net>
CC:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	KY Srinivasan <kys@...rosoft.com>,
	"olaf@...fle.de" <olaf@...fle.de>,
	"jasowang@...hat.com" <jasowang@...hat.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"driverdev-devel@...uxdriverproject.org" 
	<driverdev-devel@...uxdriverproject.org>
Subject: RE: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
 Side Scaling (vRSS)



> -----Original Message-----
> From: David Miller [mailto:davem@...emloft.net]
> Sent: Monday, March 17, 2014 4:20 PM
> To: Haiyang Zhang
> Cc: netdev@...r.kernel.org; KY Srinivasan; olaf@...fle.de;
> jasowang@...hat.com; linux-kernel@...r.kernel.org; driverdev-
> devel@...uxdriverproject.org
> Subject: Re: [PATCH net-next,v2,1/1] hyperv: Add support for virtual Receive
> Side Scaling (vRSS)
> 
> From: Haiyang Zhang <haiyangz@...rosoft.com>
> Date: Sat, 15 Mar 2014 10:18:07 -0700
> 
> > -		if (netif_queue_stopped(ndev) && !net_device->start_remove
> &&
> > -			(hv_ringbuf_avail_percent(&device->channel-
> >outbound)
> > -			> RING_AVAIL_PERCENT_HIWATER ||
> > -			num_outstanding_sends < 1))
> > -				netif_wake_queue(ndev);
> > +		if (netif_tx_queue_stopped(netdev_get_tx_queue(ndev, q_idx))
> > +			&& !net_device->start_remove &&
> > +			(hv_ringbuf_avail_percent(&channel->outbound)
> > +			> RING_AVAIL_PERCENT_HIWATER || queue_sends <
> 1))
> > +				netif_tx_wake_queue(netdev_get_tx_queue(
> > +						    ndev, q_idx));
> 
> This is not indented properly, make it:
> 
> 	if (A && B &&
> 	    (C >
>              D || E < 1))
> 
> Never put operators at the beginning of a conditional line, always at the end.

I will do. 

Thanks,
- Haiyang
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html