netdev - Re: [PATCH 6/6] net: Free skbs from irqs when possible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395149407.22343.8.camel@deadeye.wl.decadent.org.uk>
Date:	Tue, 18 Mar 2014 13:30:07 +0000
From:	Ben Hutchings <ben@...adent.org.uk>
To:	"Eric W. Biederman" <ebiederm@...ssion.com>
Cc:	David Miller <davem@...emloft.net>, stephen@...workplumber.org,
	eric.dumazet@...il.com, netdev@...r.kernel.org,
	xiyou.wangcong@...il.com, mpm@...enic.com, satyam.sharma@...il.com
Subject: Re: [PATCH 6/6] net: Free skbs from irqs when possible.

On Mon, 2014-03-17 at 23:27 -0700, Eric W. Biederman wrote:
[...]
> --- a/net/core/skbuff.c
> +++ b/net/core/skbuff.c
> @@ -554,14 +554,21 @@ static void kfree_skbmem(struct sk_buff *skb)
>  
>  static void skb_release_head_state(struct sk_buff *skb)
>  {
> +	WARN_ONCE(in_irq() && !skb_irq_freeable(skb),
> +		  "%s called from irq! sp %d nfct %d frag_list %d %pF dst %lx",
> +		  __func__,
> +		  IS_ENABLED(CONFIG_XFRM) ? !!skb->sp : 0,
> +		  IS_ENABLED(CONFIG_NF_CONNTRACK) ? !!skb->nfct : 0,
[...]

This is a syntax error if CONFIG_XFRM or CONFIG_NF_CONNTRACK is
disabled; you have to use #ifdef's.

Ben.

-- 
Ben Hutchings
Experience is directly proportional to the value of equipment destroyed.
                                                         - Carolyn Scheppner

Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)