netdev - Re: [PATCHv2 net-next] VXLAN: fix nonfunctional neigh

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140318084740.729e21a6@nehalam.linuxnetplumber.net>
Date:	Tue, 18 Mar 2014 08:47:40 -0700
From:	Stephen Hemminger <stephen@...workplumber.org>
To:	David L Stevens <dlstevens@...ibm.com>
Cc:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	Cong Wang <amwang@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCHv2 net-next] VXLAN: fix nonfunctional neigh_reduce

On Tue, 18 Mar 2014 11:21:09 -0400
David L Stevens <dlstevens@...ibm.com> wrote:

> +	struct sk_buff *reply = NULL;
> +	struct nd_msg *ns, *na;
> +	struct ipv6hdr *pip6 = ipv6_hdr(reply);

Redundant initialization of reply and pip6.
Doing ipv6_hdr(NULL) is bogus.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html