netdev - Re: [PATCH net] VXLAN: fix potential NULL dereference in arp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7O+Njk2vbfEg+RfrRJ=x1JdXTheZQwhu4PpU47Bgk2CHQ@mail.gmail.com>
Date:	Tue, 18 Mar 2014 09:53:09 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	David L Stevens <dlstevens@...ibm.com>
Cc:	David Miller <davem@...emloft.net>,
	Stephen Hemminger <shemminger@...tta.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] VXLAN: fix potential NULL dereference in arp_reduce()

On Tue, Mar 18, 2014 at 9:32 AM, David L Stevens <dlstevens@...ibm.com> wrote:
>
>         This patch fixes a NULL pointer dereference in the event of an
> skb allocation failure in arp_reduce().
>
> Signed-Off-By: David L Stevens <dlstevens@...ibm.com>
>
> diff --git a/drivers/net/vxlan.c b/drivers/net/vxlan.c
> index eb59b14..570792c 100644
> --- a/drivers/net/vxlan.c
> +++ b/drivers/net/vxlan.c
> @@ -1315,6 +1315,9 @@ static int arp_reduce(struct net_device *dev, struct sk_buff *skb)
>
>                 neigh_release(n);
>
> +               if (reply == NULL)
> +                       goto out;
> +

Nit: move it right after arp_create(). Otherwise:

Acked-by: Cong Wang <cwang@...pensource.com>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html