netdev - Re: [PATCH net] net: vxlan: fix crash when interface is created with no group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHA+R7P1DST-f9vJOfJJmjge7ATB8rYMm0XCyuCPUa6VVDpjXg@mail.gmail.com>
Date:	Tue, 18 Mar 2014 11:07:51 -0700
From:	Cong Wang <cwang@...pensource.com>
To:	David Stevens <dlstevens@...ibm.com>
Cc:	Mike Rapoport <mike.rapoport@...ellosystems.com>,
	netdev <netdev@...r.kernel.org>
Subject: Re: [PATCH net] net: vxlan: fix crash when interface is created with
 no group

On Tue, Mar 18, 2014 at 9:55 AM, David Stevens <dlstevens@...ibm.com> wrote:
>
> Wouldn't it be better to:
>
> 1) make sure all of vxlan_dev is initialized before use,
>       especially default_dst
> 2) change the v6 code to check for AF_INET6 too, and do
>       nothing if not set. If not set by the admin, the family of
>       default_dst would then be AF_UNSPEC and not match.
>

Good point! But that needs to change tx path as well, basically
all "if ( sa_family == AF_INET) ... else ...." needs to change
to "if (sa_family == AF_INET) ... else if (==AF_INET6) ... else ...".
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html