netdev - Re: [PATCH net,stable] net: cdc_ncm: fix control message ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140318.155842.1610081544107118579.davem@davemloft.net>
Date:	Tue, 18 Mar 2014 15:58:42 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	bjorn@...k.no
Cc:	netdev@...r.kernel.org, linux-usb@...r.kernel.org,
	oliver@...kum.org, alexey.orishko@...il.com, pasik@....fi,
	tschaefer@...nline.de
Subject: Re: [PATCH net,stable] net: cdc_ncm: fix control message ordering

From: Bjørn Mork <bjorn@...k.no>
Date: Mon, 17 Mar 2014 16:25:18 +0100

> This is a context modified revert of commit 6a9612e2cb22
> ("net: cdc_ncm: remove ncm_parm field") which introduced
> a NCM specification violation, causing setup errors for
> some devices. These errors resulted in the device and
> host disagreeing about shared settings, with complete
> failure to communicate as the end result.
> 
> The NCM specification require that many of the NCM specific
> control reuests are sent only while the NCM Data Interface
> is in alternate setting 0. Reverting the commit ensures that
> we follow this requirement.
> 
> Fixes: 6a9612e2cb22 ("net: cdc_ncm: remove ncm_parm field")
> Reported-and-tested-by: Pasi Kärkkäinen <pasik@....fi>
> Reported-by: Thomas Schäfer <tschaefer@...nline.de>
> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> ---
> This needs to go to v3.14 and v3.13.x stable. The bug was introduced
> in v3.13.

Applied and queued up for -stable, thanks.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html