netdev - Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with RCU_INIT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 18 Mar 2014 15:18:25 -0700
From:	"Paul E. McKenney" <paulmck@...ux.vnet.ibm.com>
To:	Monam Agarwal <monamagarwal123@...il.com>
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	eddie.wai@...adcom.com
Subject: Re: [PATCH] rcu: Replace rcu_assign_pointer(x, NULL) with
 RCU_INIT_POINTER(x, NULL)

On Wed, Mar 19, 2014 at 03:32:30AM +0530, Monam Agarwal wrote:
> This patch replaces rcu_assign_pointer(x, NULL) with RCU_INIT_POINTER(x, NULL) in drivers/infiniband/hw/qib/qib_qp.c
> 
> Signed-off-by: Monam Agarwal <monamagarwal123@...il.com>

Reviewed-by: Paul E. McKenney <paulmck@...ux.vnet.ibm.com>

> ---
>  drivers/infiniband/hw/qib/qib_qp.c |    6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/qib/qib_qp.c b/drivers/infiniband/hw/qib/qib_qp.c
> index 7e7e16f..1f5f04c 100644
> --- a/drivers/infiniband/hw/qib/qib_qp.c
> +++ b/drivers/infiniband/hw/qib/qib_qp.c
> @@ -252,10 +252,10 @@ static void remove_qp(struct qib_ibdev *dev, struct qib_qp *qp)
> 
>  	if (ibp->qp0 == qp) {
>  		atomic_dec(&qp->refcount);
> -		rcu_assign_pointer(ibp->qp0, NULL);
> +		RCU_INIT_POINTER(ibp->qp0, NULL);
>  	} else if (ibp->qp1 == qp) {
>  		atomic_dec(&qp->refcount);
> -		rcu_assign_pointer(ibp->qp1, NULL);
> +		RCU_INIT_POINTER(ibp->qp1, NULL);
>  	} else {
>  		struct qib_qp *q, **qpp;
> 
> @@ -303,7 +303,7 @@ unsigned qib_free_all_qps(struct qib_devdata *dd)
>  	spin_lock_irqsave(&dev->qpt_lock, flags);
>  	for (n = 0; n < dev->qp_table_size; n++) {
>  		qp = dev->qp_table[n];
> -		rcu_assign_pointer(dev->qp_table[n], NULL);
> +		RCU_INIT_POINTER(dev->qp_table[n], NULL);
> 
>  		for (; qp; qp = qp->next)
>  			qp_inuse++;
> -- 
> 1.7.9.5
> 

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html