netdev - Re: [PATCH] netpoll: fix the skb check in pkt_is

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJFZqHy1UZjn7+CjmODMPuNWKDQhEW_Fg9ckaGC1LYh7iU6odw@mail.gmail.com>
Date:	Tue, 18 Mar 2014 08:05:29 +0800
From:	Li RongQing <roy.qing.li@...il.com>
To:	netdev@...r.kernel.org
Cc:	Cong Wang <amwang@...hat.com>
Subject: Re: [PATCH] netpoll: fix the skb check in pkt_is_ns

this patch can be dropped since other patch has been merged into
net-next[netpoll: Remove dead packet receive code
(CONFIG_NETPOLL_TRAP)]

On Mon, Mar 17, 2014 at 4:53 PM,  <roy.qing.li@...il.com> wrote:
> From: Li RongQing <roy.qing.li@...il.com>
>
> Neighbor Solicitation is ipv6 protocol, so we should check
> skb->protocol with ETH_P_IPV6
>
> Signed-off-by: Li RongQing <roy.qing.li@...il.com>
> Cc: WANG Cong <amwang@...hat.com>
> ---
>  net/core/netpoll.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/netpoll.c b/net/core/netpoll.c
> index 570eb40..159f160 100644
> --- a/net/core/netpoll.c
> +++ b/net/core/netpoll.c
> @@ -742,7 +742,7 @@ static bool pkt_is_ns(struct sk_buff *skb)
>         struct nd_msg *msg;
>         struct ipv6hdr *hdr;
>
> -       if (skb->protocol != htons(ETH_P_ARP))
> +       if (skb->protocol != htons(ETH_P_IPV6))
>                 return false;
>         if (!pskb_may_pull(skb, sizeof(struct ipv6hdr) + sizeof(struct nd_msg)))
>                 return false;
> --
> 1.7.10.4
>
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html