netdev - Re: [net-next v2 06/15] i40e/i40evf: enable hardware feature head write back

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140319.140919.1350209156761878583.davem@davemloft.net>
Date:	Wed, 19 Mar 2014 14:09:19 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	jeffrey.t.kirsher@...el.com
Cc:	jesse.brandeburg@...el.com, netdev@...r.kernel.org,
	gospo@...hat.com, sassmann@...hat.com, mitch.a.williams@...el.com,
	catherine.sullivan@...el.com
Subject: Re: [net-next v2 06/15] i40e/i40evf: enable hardware feature head
 write back

From: Jeff Kirsher <jeffrey.t.kirsher@...el.com>
Date: Tue, 18 Mar 2014 20:42:04 -0700

> +static inline u32 i40e_get_head(struct i40e_ring *tx_ring)
> +{
> +	void *head = (struct i40e_tx_desc *)tx_ring->desc + tx_ring->count;
> +	return le32_to_cpu(*(volatile __le32 *)head);

Please put an empty line between local variable declarations and code.

> +static inline u32 i40e_get_head(struct i40e_ring *tx_ring)
> +{
> +	void *head = (struct i40e_tx_desc *)tx_ring->desc + tx_ring->count;
> +	return le32_to_cpu(*(volatile __le32 *)head);

Likewise.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html