netdev - Re: [PATCH net] ipv6: If a public address is deleted then also delete all temporary addresses still referring to it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140319202123.GH12291@order.stressinduktion.org>
Date:	Wed, 19 Mar 2014 21:21:23 +0100
From:	Hannes Frederic Sowa <hannes@...essinduktion.org>
To:	Heiner Kallweit <heiner.kallweit@....de>
Cc:	"netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: Re: [PATCH net] ipv6: If a public address is deleted then also delete all temporary addresses still referring to it

On Tue, Mar 18, 2014 at 09:46:40PM +0100, Heiner Kallweit wrote:
> If a public address is deleted by an external trigger (e.g. via inet6_rtm_deladdr) then temporary
> addresses still referring to it may remain. Happened here when the WiFi link broke and netifd
> deleted the public address. Once the link was back and prefix_rcv created new public addresses
> ipv6_create_tempaddr complained that the temporary address already existed.

Which error was it specifically?

> IMHO no temporary address should live longer than its parent, especially because ifpub of the
> temporary address still points to the then deleted public address otherwise.

Reference counting will take care of that.

> Therefore delete all related temporary addresses before a public address is deleted in inet6_addr_del
> which is called by inet6_rtm_del.

I am a bit concerend with backward compatibility here.

> Also ensure in ipv6_del_addr that no temporary address lives longer than its parent.

I currently don't see a problem with that.

Greetings,

  Hannes

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html