lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 19 Mar 2014 21:47:42 +0100 From: Thomas Graf <tgraf@...hat.com> To: Zoltan Kiss <zoltan.kiss@...rix.com>, Jesse Gross <jesse@...ira.com>, pshelar@...ira.com, dev@...nvswitch.org CC: "David S. Miller" <davem@...emloft.net>, Pablo Neira Ayuso <pablo@...filter.org>, Patrick McHardy <kaber@...sh.net>, Jozsef Kadlecsik <kadlec@...ckhole.kfki.hu>, Eric Dumazet <edumazet@...gle.com>, Daniel Borkmann <dborkman@...hat.com>, Tom Herbert <therbert@...gle.com>, Jason Wang <jasowang@...hat.com>, Florian Westphal <fw@...len.de>, Joe Perches <joe@...ches.com>, Simon Horman <horms@...ge.net.au>, Jiri Pirko <jiri@...nulli.us>, "Michael S. Tsirkin" <mst@...hat.com>, Paul Durrant <Paul.Durrant@...rix.com>, Jan Beulich <JBeulich@...e.com>, Herbert Xu <herbert@...dor.apana.org.au>, Miklos Szeredi <mszeredi@...e.cz>, netfilter-devel@...r.kernel.org, netfilter@...r.kernel.org, coreteam@...filter.org, xen-devel@...ts.xenproject.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, kvm@...r.kernel.org Subject: Re: [PATCH] core, nfqueue, openvswitch: Orphan frags in skb_zerocopy and handle errors On 03/19/2014 09:38 PM, Zoltan Kiss wrote: > skb_zerocopy can copy elements of the frags array between skbs, but it doesn't > orphan them. Also, it doesn't handle errors, so this patch takes care of that > as well. > > Signed-off-by: Zoltan Kiss <zoltan.kiss@...rix.com> > --- > + if (unlikely(skb_orphan_frags(to, GFP_ATOMIC))) { > + skb_tx_error(to); > + return -ENOMEM; > } I think you should move this down to right before we iterate over the frags. Looks good otherwise. -- To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
Powered by blists - more mailing lists