netdev - Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive Side Scaling (vRSS)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 20 Mar 2014 08:00:10 +1100
From:	Stephen Rothwell <sfr@...b.auug.org.au>
To:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
Cc:	David Miller <davem@...emloft.net>, haiyangz@...rosoft.com,
	netdev@...r.kernel.org, kys@...rosoft.com, olaf@...fle.de,
	jasowang@...hat.com, linux-kernel@...r.kernel.org,
	driverdev-devel@...uxdriverproject.org
Subject: Re: [PATCH net-next,v3] hyperv: Add support for virtual Receive
 Side Scaling (vRSS)

On Thu, 20 Mar 2014 00:56:05 +0300 Sergei Shtylyov <sergei.shtylyov@...entembedded.com> wrote:
>
> On 03/19/2014 11:40 PM, David Miller wrote:
> 
> >> +extern u8 netvsc_hash_key[];
> 
> > We no longer use extern in header file function declarations.
> 
>     Wait, this is a variable declaration. :-)

And the need for the extern on variable declarations was one reason I
gave for not removing it from the function declarations (consistency is
good :-)).

-- 
Cheers,
Stephen Rothwell                    sfr@...b.auug.org.au

Content of type "application/pgp-signature" skipped