netdev - Re: [PATCH 2/2] INTEL-IGB: Convert iounmap to pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1395203586.2050.7.camel@jtkirshe-mobl>
Date:	Tue, 18 Mar 2014 21:33:06 -0700
From:	Jeff Kirsher <jeffrey.t.kirsher@...el.com>
To:	Peter Senna Tschudin <peter.senna@...il.com>
Cc:	jesse.brandeburg@...el.com, bruce.w.allan@...el.com,
	carolyn.wyborny@...el.com, donald.c.skidmore@...el.com,
	gregory.v.rose@...el.com, alexander.h.duyck@...el.com,
	john.ronciak@...el.com, mitch.a.williams@...el.com,
	linux.nics@...el.com, e1000-devel@...ts.sourceforge.net,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org
Subject: Re: [PATCH 2/2] INTEL-IGB: Convert iounmap to pci_iounmap

On Tue, 2014-03-18 at 17:11 +0100, Peter Senna Tschudin wrote:
> Use pci_iounmap instead of iounmap when the virtual mapping was done
> with pci_iomap. A simplified version of the semantic patch that finds
> this
> issue is as follows: (http://coccinelle.lip6.fr/)
>     
> // <smpl>
> @r@
> expression addr;
> @@
> addr = pci_iomap(...)
> 
> @rr@
> expression r.addr;
> @@
> * iounmap(addr)
> // </smpl>
> 
> Signed-off-by: Peter Senna Tschudin <peter.senna@...il.com>
> ---
>  Tested by compilation only.
> 
>  drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

Thanks Peter, I have added you patch to my queue.

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)